In the Linux kernel, the following vulnerability has been resolved:
tipc: Check the bearer type before calling tipcudpnlbeareradd()
syzbot reported the following general protection fault [1]:
general protection fault, probably for non-canonical address 0xdffffc0000000010: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000080-0x0000000000000087] ... RIP: 0010:tipcudpisknownpeer+0x9c/0x250 net/tipc/udpmedia.c:291 ... Call Trace: <TASK> tipcudpnlbeareradd+0x212/0x2f0 net/tipc/udpmedia.c:646 tipcnlbeareradd+0x21e/0x360 net/tipc/bearer.c:1089 genlfamilyrcvmsgdoit+0x1fc/0x2e0 net/netlink/genetlink.c:972 genlfamilyrcvmsg net/netlink/genetlink.c:1052 [inline] genlrcvmsg+0x561/0x800 net/netlink/genetlink.c:1067 netlinkrcvskb+0x16b/0x440 net/netlink/afnetlink.c:2544 genlrcv+0x28/0x40 net/netlink/genetlink.c:1076 netlinkunicastkernel net/netlink/afnetlink.c:1341 [inline] netlinkunicast+0x53b/0x810 net/netlink/afnetlink.c:1367 netlinksendmsg+0x8b7/0xd70 net/netlink/afnetlink.c:1909 socksendmsgnosec net/socket.c:730 [inline] socksendmsg+0xd5/0x180 net/socket.c:745 syssendmsg+0x6ac/0x940 net/socket.c:2584 _syssendmsg+0x135/0x1d0 net/socket.c:2638 _syssendmsg+0x117/0x1e0 net/socket.c:2667 dosyscallx64 arch/x86/entry/common.c:52 [inline] dosyscall64+0x40/0x110 arch/x86/entry/common.c:83 entrySYSCALL64afterhwframe+0x63/0x6b
The cause of this issue is that when tipcnlbeareradd() is called with the TIPCNLABEARERUDPOPTS attribute, tipcudpnlbearer_add() is called even if the bearer is not UDP.
tipcudpisknownpeer() called by tipcudpnlbeareradd() assumes that the mediaptr field of the tipcbearer has an udp_bearer type object, so the function goes crazy for non-UDP bearers.
This patch fixes the issue by checking the bearer type before calling tipcudpnlbeareradd() in tipcnlbearer_add().
[
{
"digest": {
"threshold": 0.9,
"line_hashes": [
"172142183977303866975680539918556435373",
"11992444616563630911151442242953071978",
"107410027860265453665658068189465039292",
"92809720980265598322027177117109085313"
]
},
"signature_type": "Line",
"target": {
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3871aa01e1a779d866fa9dfdd5a836f342f4eb87",
"id": "CVE-2024-26663-000e9933"
},
{
"digest": {
"threshold": 0.9,
"line_hashes": [
"172142183977303866975680539918556435373",
"11992444616563630911151442242953071978",
"107410027860265453665658068189465039292",
"92809720980265598322027177117109085313"
]
},
"signature_type": "Line",
"target": {
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@19d7314f2fb9515bdaac9829d4d8eb34edd1fe95",
"id": "CVE-2024-26663-05969248"
},
{
"digest": {
"function_hash": "66786590175308168963889999122975506872",
"length": 848.0
},
"signature_type": "Function",
"target": {
"function": "tipc_nl_bearer_add",
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3871aa01e1a779d866fa9dfdd5a836f342f4eb87",
"id": "CVE-2024-26663-0e57a37a"
},
{
"digest": {
"function_hash": "66786590175308168963889999122975506872",
"length": 848.0
},
"signature_type": "Function",
"target": {
"function": "tipc_nl_bearer_add",
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3d3a5b31b43515b5752ff282702ca546ec3e48b6",
"id": "CVE-2024-26663-5b4c485d"
},
{
"digest": {
"threshold": 0.9,
"line_hashes": [
"172142183977303866975680539918556435373",
"11992444616563630911151442242953071978",
"107410027860265453665658068189465039292",
"92809720980265598322027177117109085313"
]
},
"signature_type": "Line",
"target": {
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@0cd331dfd6023640c9669d0592bc0fd491205f87",
"id": "CVE-2024-26663-68e6e849"
},
{
"digest": {
"function_hash": "66786590175308168963889999122975506872",
"length": 848.0
},
"signature_type": "Function",
"target": {
"function": "tipc_nl_bearer_add",
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@888e3524be87f3df9fa3c083484e4b62b3e3bb59",
"id": "CVE-2024-26663-745c30f4"
},
{
"digest": {
"function_hash": "66786590175308168963889999122975506872",
"length": 848.0
},
"signature_type": "Function",
"target": {
"function": "tipc_nl_bearer_add",
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@0cd331dfd6023640c9669d0592bc0fd491205f87",
"id": "CVE-2024-26663-99993aca"
},
{
"digest": {
"function_hash": "66786590175308168963889999122975506872",
"length": 848.0
},
"signature_type": "Function",
"target": {
"function": "tipc_nl_bearer_add",
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@c1701ea85ef0ec7be6a1b36c7da69f572ed2fd12",
"id": "CVE-2024-26663-a01c0491"
},
{
"digest": {
"threshold": 0.9,
"line_hashes": [
"172142183977303866975680539918556435373",
"11992444616563630911151442242953071978",
"107410027860265453665658068189465039292",
"92809720980265598322027177117109085313"
]
},
"signature_type": "Line",
"target": {
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3d3a5b31b43515b5752ff282702ca546ec3e48b6",
"id": "CVE-2024-26663-ad1d0c7c"
},
{
"digest": {
"function_hash": "66786590175308168963889999122975506872",
"length": 848.0
},
"signature_type": "Function",
"target": {
"function": "tipc_nl_bearer_add",
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@6f70f0b412458c622a12d4292782c8e92e210c2f",
"id": "CVE-2024-26663-b833c4ec"
},
{
"digest": {
"threshold": 0.9,
"line_hashes": [
"172142183977303866975680539918556435373",
"11992444616563630911151442242953071978",
"107410027860265453665658068189465039292",
"92809720980265598322027177117109085313"
]
},
"signature_type": "Line",
"target": {
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@6f70f0b412458c622a12d4292782c8e92e210c2f",
"id": "CVE-2024-26663-c33d2539"
},
{
"digest": {
"function_hash": "66786590175308168963889999122975506872",
"length": 848.0
},
"signature_type": "Function",
"target": {
"function": "tipc_nl_bearer_add",
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@24ec8f0da93b8a9fba11600be8a90f0d73fb46f1",
"id": "CVE-2024-26663-ca25b76e"
},
{
"digest": {
"threshold": 0.9,
"line_hashes": [
"172142183977303866975680539918556435373",
"11992444616563630911151442242953071978",
"107410027860265453665658068189465039292",
"92809720980265598322027177117109085313"
]
},
"signature_type": "Line",
"target": {
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@c1701ea85ef0ec7be6a1b36c7da69f572ed2fd12",
"id": "CVE-2024-26663-d788fe80"
},
{
"digest": {
"threshold": 0.9,
"line_hashes": [
"172142183977303866975680539918556435373",
"11992444616563630911151442242953071978",
"107410027860265453665658068189465039292",
"92809720980265598322027177117109085313"
]
},
"signature_type": "Line",
"target": {
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@24ec8f0da93b8a9fba11600be8a90f0d73fb46f1",
"id": "CVE-2024-26663-e3d06cfa"
},
{
"digest": {
"function_hash": "66786590175308168963889999122975506872",
"length": 848.0
},
"signature_type": "Function",
"target": {
"function": "tipc_nl_bearer_add",
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@19d7314f2fb9515bdaac9829d4d8eb34edd1fe95",
"id": "CVE-2024-26663-efb2608d"
},
{
"digest": {
"threshold": 0.9,
"line_hashes": [
"172142183977303866975680539918556435373",
"11992444616563630911151442242953071978",
"107410027860265453665658068189465039292",
"92809720980265598322027177117109085313"
]
},
"signature_type": "Line",
"target": {
"file": "net/tipc/bearer.c"
},
"deprecated": false,
"signature_version": "v1",
"source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@888e3524be87f3df9fa3c083484e4b62b3e3bb59",
"id": "CVE-2024-26663-f73a4a08"
}
]