CVE-2024-50093

The processorthermal driver uses pcimdeviceenable() to enable a PCI device, which means the device will be automatically disabled on driver detach. Thus there is no need to call pcidisable_device() again on it.

With recent PCI device resource management improvements, e.g. commit f748a07a0b64 ("PCI: Remove legacy pcim_release()"), this problem is exposed and triggers the warining below.

[ 224.010735] procthermalpci 0000:00:04.0: disabling already-disabled device [ 224.010747] WARNING: CPU: 8 PID: 4442 at drivers/pci/pci.c:2250 pcidisabledevice+0xe5/0x100 ... [ 224.010844] Call Trace: [ 224.010845] <TASK> [ 224.010847] ? showregs+0x6d/0x80 [ 224.010851] ? _warn+0x8c/0x140 [ 224.010854] ? pcidisabledevice+0xe5/0x100 [ 224.010856] ? reportbug+0x1c9/0x1e0 [ 224.010859] ? handlebug+0x46/0x80 [ 224.010862] ? excinvalidop+0x1d/0x80 [ 224.010863] ? asmexcinvalidop+0x1f/0x30 [ 224.010867] ? pcidisabledevice+0xe5/0x100 [ 224.010869] ? pcidisabledevice+0xe5/0x100 [ 224.010871] ? kfree+0x21a/0x2b0 [ 224.010873] pcimdisabledevice+0x20/0x30 [ 224.010875] devmactionrelease+0x16/0x20 [ 224.010878] releasenodes+0x47/0xc0 [ 224.010880] devresreleaseall+0x9f/0xe0 [ 224.010883] deviceunbindcleanup+0x12/0x80 [ 224.010885] devicereleasedriverinternal+0x1ca/0x210 [ 224.010887] driverdetach+0x4e/0xa0 [ 224.010889] busremovedriver+0x6f/0xf0 [ 224.010890] driverunregister+0x35/0x60 [ 224.010892] pciunregisterdriver+0x44/0x90 [ 224.010894] procthermalpcidriverexit+0x14/0x5f0 [processorthermaldevicepci] ... [ 224.010921] ---[ end trace 0000000000000000 ]---

Remove the excess pcidisabledevice() calls.

[ rjw: Subject and changelog edits ]

References

Affected packages

Git / git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git

Affected ranges

Type: GIT
Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Events: Introduced

acd65d5d1cf4a3324c8970ba74632abe069fe23e

Fixed

8403021b6f32d68a7e3a6b8428ecaf5c153a9974

Type: GIT
Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Events: Introduced

acd65d5d1cf4a3324c8970ba74632abe069fe23e

Fixed

b4ab78f4adeaf6c98be5d375518dd4fb666eac5e

Type: GIT
Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Events: Introduced

acd65d5d1cf4a3324c8970ba74632abe069fe23e

Fixed

dd64ea03375618684477f946be4f5e253f8676c2

Type: GIT
Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Events: Introduced

acd65d5d1cf4a3324c8970ba74632abe069fe23e

Fixed

434525a864136c928b54fd2512b4c0167c207463

Type: GIT
Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
Events: Introduced

acd65d5d1cf4a3324c8970ba74632abe069fe23e

Fixed

99ca0b57e49fb73624eede1c4396d9e3d10ccf14

Affected versions

v5.*

v5.13

v5.13-rc6

v5.13-rc7

v5.14

v5.14-rc1

v5.14-rc2

v5.14-rc3

v5.14-rc4

v5.14-rc5

v5.14-rc6

v5.14-rc7

v5.15

v5.15-rc1

v5.15-rc2

v5.15-rc3

v5.15-rc4

v5.15-rc5

v5.15-rc6

v5.15-rc7

v5.15.1

v5.15.10

v5.15.100

v5.15.101

v5.15.102

v5.15.103

v5.15.104

v5.15.105

v5.15.106

v5.15.107

v5.15.108

v5.15.109

v5.15.11

v5.15.110

v5.15.111

v5.15.112

v5.15.113

v5.15.114

v5.15.115

v5.15.116

v5.15.117

v5.15.118

v5.15.119

v5.15.12

v5.15.120

v5.15.121

v5.15.122

v5.15.123

v5.15.124

v5.15.125

v5.15.126

v5.15.127

v5.15.128

v5.15.129

v5.15.13

v5.15.130

v5.15.131

v5.15.132

v5.15.133

v5.15.134

v5.15.135

v5.15.136

v5.15.137

v5.15.138

v5.15.139

v5.15.14

v5.15.140

v5.15.141

v5.15.142

v5.15.143

v5.15.144

v5.15.145

v5.15.146

v5.15.147

v5.15.148

v5.15.149

v5.15.15

v5.15.150

v5.15.151

v5.15.152

v5.15.153

v5.15.154

v5.15.155

v5.15.156

v5.15.157

v5.15.158

v5.15.159

v5.15.16

v5.15.160

v5.15.161

v5.15.162

v5.15.163

v5.15.164

v5.15.165

v5.15.166

v5.15.167

v5.15.17

v5.15.18

v5.15.19

v5.15.2

v5.15.20

v5.15.21

v5.15.22

v5.15.23

v5.15.24

v5.15.25

v5.15.26

v5.15.27

v5.15.28

v5.15.29

v5.15.3

v5.15.30

v5.15.31

v5.15.32

v5.15.33

v5.15.34

v5.15.35

v5.15.36

v5.15.37

v5.15.38

v5.15.39

v5.15.4

v5.15.40

v5.15.41

v5.15.42

v5.15.43

v5.15.44

v5.15.45

v5.15.46

v5.15.47

v5.15.48

v5.15.49

v5.15.5

v5.15.50

v5.15.51

v5.15.52

v5.15.53

v5.15.54

v5.15.55

v5.15.56

v5.15.57

v5.15.58

v5.15.59

v5.15.6

v5.15.60

v5.15.61

v5.15.62

v5.15.63

v5.15.64

v5.15.65

v5.15.66

v5.15.67

v5.15.68

v5.15.69

v5.15.7

v5.15.70

v5.15.71

v5.15.72

v5.15.73

v5.15.74

v5.15.75

v5.15.76

v5.15.77

v5.15.78

v5.15.79

v5.15.8

v5.15.80

v5.15.81

v5.15.82

v5.15.83

v5.15.84

v5.15.85

v5.15.86

v5.15.87

v5.15.88

v5.15.89

v5.15.9

v5.15.90

v5.15.91

v5.15.92

v5.15.93

v5.15.94

v5.15.95

v5.15.96

v5.15.97

v5.15.98

v5.15.99

v5.16

v5.16-rc1

v5.16-rc2

v5.16-rc3

v5.16-rc4

v5.16-rc5

v5.16-rc6

v5.16-rc7

v5.16-rc8

v5.17

v5.17-rc1

v5.17-rc2

v5.17-rc3

v5.17-rc4

v5.17-rc5

v5.17-rc6

v5.17-rc7

v5.17-rc8

v5.18

v5.18-rc1

v5.18-rc2

v5.18-rc3

v5.18-rc4

v5.18-rc5

v5.18-rc6

v5.18-rc7

v5.19

v5.19-rc1

v5.19-rc2

v5.19-rc3

v5.19-rc4

v5.19-rc5

v5.19-rc6

v5.19-rc7

v5.19-rc8

v6.*

v6.0

v6.0-rc1

v6.0-rc2

v6.0-rc3

v6.0-rc4

v6.0-rc5

v6.0-rc6

v6.0-rc7

v6.1

v6.1-rc1

v6.1-rc2

v6.1-rc3

v6.1-rc4

v6.1-rc5

v6.1-rc6

v6.1-rc7

v6.1-rc8

v6.1.1

v6.1.10

v6.1.100

v6.1.101

v6.1.102

v6.1.103

v6.1.104

v6.1.105

v6.1.106

v6.1.107

v6.1.108

v6.1.109

v6.1.11

v6.1.110

v6.1.111

v6.1.112

v6.1.12

v6.1.13

v6.1.14

v6.1.15

v6.1.16

v6.1.17

v6.1.18

v6.1.19

v6.1.2

v6.1.20

v6.1.21

v6.1.22

v6.1.23

v6.1.24

v6.1.25

v6.1.26

v6.1.27

v6.1.28

v6.1.29

v6.1.3

v6.1.30

v6.1.31

v6.1.32

v6.1.33

v6.1.34

v6.1.35

v6.1.36

v6.1.37

v6.1.38

v6.1.39

v6.1.4

v6.1.40

v6.1.41

v6.1.42

v6.1.43

v6.1.44

v6.1.45

v6.1.46

v6.1.47

v6.1.48

v6.1.49

v6.1.5

v6.1.50

v6.1.51

v6.1.52

v6.1.53

v6.1.54

v6.1.55

v6.1.56

v6.1.57

v6.1.58

v6.1.59

v6.1.6

v6.1.60

v6.1.61

v6.1.62

v6.1.63

v6.1.64

v6.1.65

v6.1.66

v6.1.67

v6.1.68

v6.1.69

v6.1.7

v6.1.70

v6.1.71

v6.1.72

v6.1.73

v6.1.74

v6.1.75

v6.1.76

v6.1.77

v6.1.78

v6.1.79

v6.1.8

v6.1.80

v6.1.81

v6.1.82

v6.1.83

v6.1.84

v6.1.85

v6.1.86

v6.1.87

v6.1.88

v6.1.89

v6.1.9

v6.1.90

v6.1.91

v6.1.92

v6.1.93

v6.1.94

v6.1.95

v6.1.96

v6.1.97

v6.1.98

v6.1.99

v6.10

v6.10-rc1

v6.10-rc2

v6.10-rc3

v6.10-rc4

v6.10-rc5

v6.10-rc6

v6.10-rc7

v6.11

v6.11-rc1

v6.11-rc2

v6.11-rc3

v6.11-rc4

v6.11-rc5

v6.11-rc6

v6.11-rc7

v6.11.1

v6.11.2

v6.11.3

v6.12-rc1

v6.2

v6.2-rc1

v6.2-rc2

v6.2-rc3

v6.2-rc4

v6.2-rc5

v6.2-rc6

v6.2-rc7

v6.2-rc8

v6.3

v6.3-rc1

v6.3-rc2

v6.3-rc3

v6.3-rc4

v6.3-rc5

v6.3-rc6

v6.3-rc7

v6.4

v6.4-rc1

v6.4-rc2

v6.4-rc3

v6.4-rc4

v6.4-rc5

v6.4-rc6

v6.4-rc7

v6.5

v6.5-rc1

v6.5-rc2

v6.5-rc3

v6.5-rc4

v6.5-rc5

v6.5-rc6

v6.5-rc7

v6.6

v6.6-rc1

v6.6-rc2

v6.6-rc3

v6.6-rc4

v6.6-rc5

v6.6-rc6

v6.6-rc7

v6.6.1

v6.6.10

v6.6.11

v6.6.12

v6.6.13

v6.6.14

v6.6.15

v6.6.16

v6.6.17

v6.6.18

v6.6.19

v6.6.2

v6.6.20

v6.6.21

v6.6.22

v6.6.23

v6.6.24

v6.6.25

v6.6.26

v6.6.27

v6.6.28

v6.6.29

v6.6.3

v6.6.30

v6.6.31

v6.6.32

v6.6.33

v6.6.34

v6.6.35

v6.6.36

v6.6.37

v6.6.38

v6.6.39

v6.6.4

v6.6.40

v6.6.41

v6.6.42

v6.6.43

v6.6.44

v6.6.45

v6.6.46

v6.6.47

v6.6.48

v6.6.49

v6.6.5

v6.6.50

v6.6.51

v6.6.52

v6.6.53

v6.6.54

v6.6.55

v6.6.56

v6.6.6

v6.6.7

v6.6.8

v6.6.9

v6.7

v6.7-rc1

v6.7-rc2

v6.7-rc3

v6.7-rc4

v6.7-rc5

v6.7-rc6

v6.7-rc7

v6.7-rc8

v6.8

v6.8-rc1

v6.8-rc2

v6.8-rc3

v6.8-rc4

v6.8-rc5

v6.8-rc6

v6.8-rc7

v6.9

v6.9-rc1

v6.9-rc2

v6.9-rc3

v6.9-rc4

v6.9-rc5

v6.9-rc6

v6.9-rc7

Database specific

vanir_signatures

[
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@99ca0b57e49fb73624eede1c4396d9e3d10ccf14",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-009aed0e",
        "target": {
            "function": "proc_thermal_pci_probe",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 1942.0,
            "function_hash": "41632191842010627998958055831120267525"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@434525a864136c928b54fd2512b4c0167c207463",
        "signature_version": "v1",
        "signature_type": "Line",
        "id": "CVE-2024-50093-12e5ba0d",
        "target": {
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "line_hashes": [
                "219892503491746394720150180009201999697",
                "248166752764397524306970384661752803066",
                "91055358232137573155115709628792359592",
                "155906269834508497710582446683325961997",
                "45680468528159024481396470012966981141",
                "170517413033385515781612524438869299281",
                "33251111405922777560733211132224128742",
                "13982960588000006414101413768406699952"
            ],
            "threshold": 0.9
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@8403021b6f32d68a7e3a6b8428ecaf5c153a9974",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-22d2484d",
        "target": {
            "function": "proc_thermal_pci_remove",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 447.0,
            "function_hash": "154263747682946613798976374093180689997"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@8403021b6f32d68a7e3a6b8428ecaf5c153a9974",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-268e4320",
        "target": {
            "function": "proc_thermal_pci_probe",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 1746.0,
            "function_hash": "286027108034900069562018512051859259517"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@99ca0b57e49fb73624eede1c4396d9e3d10ccf14",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-564d597d",
        "target": {
            "function": "proc_thermal_pci_remove",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 417.0,
            "function_hash": "25458733116666060891018735100891737722"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@dd64ea03375618684477f946be4f5e253f8676c2",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-586d0e66",
        "target": {
            "function": "proc_thermal_pci_remove",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 447.0,
            "function_hash": "154263747682946613798976374093180689997"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@434525a864136c928b54fd2512b4c0167c207463",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-5f93f054",
        "target": {
            "function": "proc_thermal_pci_remove",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 417.0,
            "function_hash": "25458733116666060891018735100891737722"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@dd64ea03375618684477f946be4f5e253f8676c2",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-6e8caa40",
        "target": {
            "function": "proc_thermal_pci_probe",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 1872.0,
            "function_hash": "157501648028463094288516092422230270567"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@8403021b6f32d68a7e3a6b8428ecaf5c153a9974",
        "signature_version": "v1",
        "signature_type": "Line",
        "id": "CVE-2024-50093-86e0490c",
        "target": {
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "line_hashes": [
                "219892503491746394720150180009201999697",
                "248166752764397524306970384661752803066",
                "91055358232137573155115709628792359592",
                "155906269834508497710582446683325961997",
                "45680468528159024481396470012966981141",
                "170517413033385515781612524438869299281",
                "33251111405922777560733211132224128742",
                "13982960588000006414101413768406699952"
            ],
            "threshold": 0.9
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@b4ab78f4adeaf6c98be5d375518dd4fb666eac5e",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-89f8c72b",
        "target": {
            "function": "proc_thermal_pci_remove",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 447.0,
            "function_hash": "154263747682946613798976374093180689997"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@99ca0b57e49fb73624eede1c4396d9e3d10ccf14",
        "signature_version": "v1",
        "signature_type": "Line",
        "id": "CVE-2024-50093-b5a78e79",
        "target": {
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "line_hashes": [
                "219892503491746394720150180009201999697",
                "248166752764397524306970384661752803066",
                "91055358232137573155115709628792359592",
                "155906269834508497710582446683325961997",
                "45680468528159024481396470012966981141",
                "170517413033385515781612524438869299281",
                "33251111405922777560733211132224128742",
                "13982960588000006414101413768406699952"
            ],
            "threshold": 0.9
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@dd64ea03375618684477f946be4f5e253f8676c2",
        "signature_version": "v1",
        "signature_type": "Line",
        "id": "CVE-2024-50093-bb726251",
        "target": {
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "line_hashes": [
                "219892503491746394720150180009201999697",
                "248166752764397524306970384661752803066",
                "91055358232137573155115709628792359592",
                "155906269834508497710582446683325961997",
                "45680468528159024481396470012966981141",
                "170517413033385515781612524438869299281",
                "33251111405922777560733211132224128742",
                "13982960588000006414101413768406699952"
            ],
            "threshold": 0.9
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@b4ab78f4adeaf6c98be5d375518dd4fb666eac5e",
        "signature_version": "v1",
        "signature_type": "Line",
        "id": "CVE-2024-50093-c2811cb2",
        "target": {
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "line_hashes": [
                "219892503491746394720150180009201999697",
                "248166752764397524306970384661752803066",
                "91055358232137573155115709628792359592",
                "155906269834508497710582446683325961997",
                "45680468528159024481396470012966981141",
                "170517413033385515781612524438869299281",
                "33251111405922777560733211132224128742",
                "13982960588000006414101413768406699952"
            ],
            "threshold": 0.9
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@b4ab78f4adeaf6c98be5d375518dd4fb666eac5e",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-c3244b3c",
        "target": {
            "function": "proc_thermal_pci_probe",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 1746.0,
            "function_hash": "286027108034900069562018512051859259517"
        },
        "deprecated": false
    },
    {
        "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@434525a864136c928b54fd2512b4c0167c207463",
        "signature_version": "v1",
        "signature_type": "Function",
        "id": "CVE-2024-50093-c3bdbac7",
        "target": {
            "function": "proc_thermal_pci_probe",
            "file": "drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c"
        },
        "digest": {
            "length": 1942.0,
            "function_hash": "41632191842010627998958055831120267525"
        },
        "deprecated": false
    }
]

Linux / Kernel

Package

Name: Kernel

Affected ranges

Type: ECOSYSTEM
Events: Introduced

5.14.0

Fixed

5.15.168

Type: ECOSYSTEM
Events: Introduced

5.16.0

Fixed

6.1.113

Type: ECOSYSTEM
Events: Introduced

6.2.0

Fixed

6.6.57

Type: ECOSYSTEM
Events: Introduced

6.7.0

Fixed

6.11.4