GHSA-2x65-fpch-2fcm
Suggest an improvement- Source
- https://github.com/advisories/GHSA-2x65-fpch-2fcm
- Import Source
- https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/12/GHSA-2x65-fpch-2fcm/GHSA-2x65-fpch-2fcm.json
- JSON Data
- https://api.test.osv.dev/v1/vulns/GHSA-2x65-fpch-2fcm
- Aliases
-
- CVE-2024-52596
- Published
- 2024-12-02T17:14:30Z
- Modified
- 2024-12-12T22:23:17.391999Z
- Severity
-
- 8.8 (High) CVSS_V4 - CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:N/VA:H/SC:L/SI:L/SA:N CVSS Calculator
- Summary
- SimpleSAMLphp xml-common XXE vulnerability
- Details
-
Summary
When loading an (untrusted) XML document, for example the SAMLResponse, it's possible to induce an XXE.
$options is defined as: https://github.com/simplesamlphp/xml-common/blob/v1.19.0/src/DOMDocumentFactory.php#L39 including the DTDLoad option, which allows an attacker to read file contents from local file system OR internal network.
While there is the NONET option, an attacker can simply bypass if by using PHP filters: php://filter/convert.base64-encode/resource=http://URL OR FILE
From there an attacker can induce network connections and steal the targeted file OOB (haven't fully tested this).
RCE may be possible with the php://expect or php://phar wrappers, but this hasn't been tested.
Note: The mitigation here: https://github.com/simplesamlphp/xml-common/blob/v1.19.0/src/DOMDocumentFactory.php#L58 Comes too late, as the XML has already been loaded into a document. Mitigation:
Remove the LIBXMLDTDLOAD | LIBXMLDTDATTR options. Additionally, as a defense in depth measure, check if there is the string:
- Database specific
{ "nvd_published_at": "2024-12-02T17:15:12Z", "cwe_ids": [ "CWE-611" ], "severity": "HIGH", "github_reviewed": true, "github_reviewed_at": "2024-12-02T17:14:30Z" }- References
-
- https://github.com/simplesamlphp/xml-common/security/advisories/GHSA-2x65-fpch-2fcm
- https://nvd.nist.gov/vuln/detail/CVE-2024-52596
- https://github.com/simplesamlphp/xml-common/commit/fa4ade391c3194466acf5fbfd5d2ecdbf5e831f5
- https://github.com/simplesamlphp/xml-common
- https://lists.debian.org/debian-lts-announce/2024/12/msg00001.html
Affected packages
Packagist / simplesamlphp/xml-common
Package
- Name
- simplesamlphp/xml-common
- Purl
- pkg:composer/simplesamlphp/xml-common
Affected ranges
- Type
- ECOSYSTEM
- Events
-
Introduced0Unknown introduced version / All previous versions are affectedFixed1.20.0