CVE-2022-50728

In the Linux kernel, the following vulnerability has been resolved:

s390/lcs: Fix return type of lcsstartxmit()

With clang's kernel control flow integrity (kCFI, CONFIGCFICLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical, there is a failure at run time, which manifests as either a kernel panic or thread getting killed. A proposed warning in clang aims to catch these at compile time, which reveals:

drivers/s390/net/lcs.c:2090:21: error: incompatible function pointer types initializing 'netdevtxt (*)(struct skbuff *, struct netdevice )' (aka 'enum netdev_tx ()(struct sk_buff *, struct netdevice *)') with an expression of type 'int (struct skbuff *, struct netdevice *)' [-Werror,-Wincompatible-function-pointer-types-strict] .ndostartxmit = lcsstartxmit, ^~~~~~~~~~~~~~ drivers/s390/net/lcs.c:2097:21: error: incompatible function pointer types initializing 'netdevtxt (*)(struct skbuff , struct netdevice *)' (aka 'enum netdevtx ()(struct skbuff *, struct netdevice *)') with an expression of type 'int (struct skbuff *, struct netdevice *)' [-Werror,-Wincompatible-function-pointer-types-strict] .ndostartxmit = lcsstartxmit, ^~~~~~~~~~~~~~

->ndostartxmit() in 'struct netdeviceops' expects a return type of 'netdevtxt', not 'int'. Adjust the return type of lcsstartxmit() to match the prototype's to resolve the warning and potential CFI failure, should s390 select ARCHSUPPORTSCFI_CLANG in the future.