In the Linux kernel, the following vulnerability has been resolved:
btrfs: fix race in readextentbuffer_pages()
There are reports from tree-checker that detects corrupted nodes, without any obvious pattern so possibly an overwrite in memory. After some debugging it turns out there's a race when reading an extent buffer the uptodate status can be missed.
To prevent concurrent reads for the same extent buffer, readextentbuffer_pages() performs these checks:
/* (1) */
if (test_bit(EXTENT_BUFFER_UPTODATE, &eb->bflags))
return 0;
/* (2) */
if (test_and_set_bit(EXTENT_BUFFER_READING, &eb->bflags))
goto done;
At this point, it seems safe to start the actual read operation. Once that completes, endbbiometa_read() does
/* (3) */
set_extent_buffer_uptodate(eb);
/* (4) */
clear_bit(EXTENT_BUFFER_READING, &eb->bflags);
Normally, this is enough to ensure only one read happens, and all other callers wait for it to finish before returning. Unfortunately, there is a racey interleaving:
Thread A | Thread B | Thread C
---------+----------+---------
(1) | |
| (1) |
(2) | |
(3) | |
(4) | |
| (2) |
| | (1)
When this happens, thread B kicks of an unnecessary read. Worse, thread C will see UPTODATE set and return immediately, while the read from thread B is still in progress. This race could result in tree-checker errors like this as the extent buffer is concurrently modified:
BTRFS critical (device dm-0): corrupted node, root=256
block=8550954455682405139 owner mismatch, have 11858205567642294356
expect [256, 18446744073709551360]
Fix it by testing UPTODATE again after setting the READING bit, and if it's been set, skip the unnecessary read.
[ minor update of changelog ]
{ "vanir_signatures": [ { "signature_type": "Function", "target": { "file": "fs/btrfs/extent_io.c", "function": "read_extent_buffer_pages" }, "id": "CVE-2024-35798-28ce243e", "digest": { "length": 1397.0, "function_hash": "233449174880835031269030745993448101648" }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@0427c8ef8bbb7f304de42ef51d69c960e165e052", "deprecated": false, "signature_version": "v1" }, { "signature_type": "Line", "target": { "file": "fs/btrfs/extent_io.c" }, "id": "CVE-2024-35798-2d6635f9", "digest": { "threshold": 0.9, "line_hashes": [ "244860295154560914661115200884769415830", "151550505142823828944155927973984918043", "176825488235561253652456416284285015049" ] }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@2885d54af2c2e1d910e20d5c8045bae40e02fbc1", "deprecated": false, "signature_version": "v1" }, { "signature_type": "Function", "target": { "file": "fs/btrfs/extent_io.c", "function": "read_extent_buffer_pages" }, "id": "CVE-2024-35798-362a0e41", "digest": { "length": 1486.0, "function_hash": "259234399510024586390112242357818798583" }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@2885d54af2c2e1d910e20d5c8045bae40e02fbc1", "deprecated": false, "signature_version": "v1" }, { "signature_type": "Line", "target": { "file": "fs/btrfs/extent_io.c" }, "id": "CVE-2024-35798-69e15242", "digest": { "threshold": 0.9, "line_hashes": [ "244860295154560914661115200884769415830", "151550505142823828944155927973984918043", "176825488235561253652456416284285015049" ] }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@ef1e68236b9153c27cb7cf29ead0c532870d4215", "deprecated": false, "signature_version": "v1" }, { "signature_type": "Line", "target": { "file": "fs/btrfs/extent_io.c" }, "id": "CVE-2024-35798-70e4d510", "digest": { "threshold": 0.9, "line_hashes": [ "244860295154560914661115200884769415830", "151550505142823828944155927973984918043", "176825488235561253652456416284285015049" ] }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@0427c8ef8bbb7f304de42ef51d69c960e165e052", "deprecated": false, "signature_version": "v1" }, { "signature_type": "Line", "target": { "file": "fs/btrfs/extent_io.c" }, "id": "CVE-2024-35798-9b12b8dc", "digest": { "threshold": 0.9, "line_hashes": [ "244860295154560914661115200884769415830", "151550505142823828944155927973984918043", "176825488235561253652456416284285015049" ] }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3a25878a3378adce5d846300c9570f15aa7f7a80", "deprecated": false, "signature_version": "v1" }, { "signature_type": "Function", "target": { "file": "fs/btrfs/extent_io.c", "function": "read_extent_buffer_pages" }, "id": "CVE-2024-35798-ce1241f3", "digest": { "length": 1397.0, "function_hash": "233449174880835031269030745993448101648" }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@3a25878a3378adce5d846300c9570f15aa7f7a80", "deprecated": false, "signature_version": "v1" }, { "signature_type": "Function", "target": { "file": "fs/btrfs/extent_io.c", "function": "read_extent_buffer_pages" }, "id": "CVE-2024-35798-f20480a5", "digest": { "length": 1489.0, "function_hash": "117316053210905963425233943332691565237" }, "source": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git@ef1e68236b9153c27cb7cf29ead0c532870d4215", "deprecated": false, "signature_version": "v1" } ] }