In the Linux kernel, the following vulnerability has been resolved:

bridge: Fix sleep in atomic context in netlink path

Since the introduction of the netlink configuration path for bridge ports in commit 25c71c75ac87 ("bridge: bridge port parameters over netlink"), br_setport() was always called with the bridge lock held around it. Back then this decision made sense: The bridge lock protects the STP state of the bridge and its ports and at that time the function only processed three STP related netlink attributes (cost, priority and state).

Nowadays, br_setport() processes a lot more attributes and most of them do not need the bridge lock:

• Bridge flags: Only require RTNL. Read locklessly by the data path. Annotations can be added in net-next.

• FDB port flushing: Only requires the FDB lock.

• Multicast attributes: Only require the multicast lock.

• Group forward mask: Only requires RTNL. Read locklessly by the data path. Annotations can be added in net-next.

• Backup port and NHID: Only require RTNL. Read locklessly by the data path.

This is a problem as the bridge calls devsetpromiscuity() when certain bridge port flags change and this function can sleep since the commit cited below, resulting in a splat such as [1].

Fix this by reducing the scope of the bridge lock and only take it when processing the three STP related attributes that require it. This is consistent with the multicast attributes where each attribute acquires the multicast lock instead of having one critical section for all relevant attributes.

[1] BUG: sleeping function called from invalid context at net/core/devaddrlists.c:1262 inatomic(): 1, irqsdisabled(): 0, nonblock: 0, pid: 356, name: bridge preemptcount: 201, expected: 0 RCU nest depth: 0, expected: 0 2 locks held by bridge/356:

0: ffffffff919473a0 (rtnlmutex){+.+.}-{4:4}, at: rtnetlinkrcv_msg (net/core/rtnetlink.c:80 net/core/rtnetlink.c:7002)

1: ffff888115072d58 (&br->lock){+...}-{3:3}, at: brsetlink (./include/linux/spinlock.h:348 net/bridge/brnetlink.c:1117)

Preemption disabled at: 0x0 Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 Call Trace: <TASK> dumpstacklvl (lib/dumpstack.c:94 lib/dumpstack.c:120) __mightresched.cold (kernel/sched/core.c:9163) netifrx_moderun (net/core/devaddrlists.c:1262) netifrxmodesync (net/core/devaddrlists.c:1428) devsetpromiscuity (net/core/devapi.c:289) brmanagepromisc (net/bridge/brif.c:135 net/bridge/brif.c:172) brportflagschange (net/bridge/brif.c:242 net/bridge/brif.c:747) brsetport (net/bridge/brnetlink.c:1000) brsetlink (net/bridge/brnetlink.c:1118) rtnlbridgesetlink (net/core/rtnetlink.c:5572) rtnetlinkrcvmsg (net/core/rtnetlink.c:7005) netlinkrcvskb (net/netlink/afnetlink.c:2550) netlinkunicast (net/netlink/afnetlink.c:1318 net/netlink/afnetlink.c:1344) netlinksendmsg (net/netlink/afnetlink.c:1894) __sock_sendmsg (net/socket.c:787 (discriminator 4) net/socket.c:802 (discriminator 4)) ____sys_sendmsg (net/socket.c:2698) ___sys_sendmsg (net/socket.c:2752) __syssendmsg (net/socket.c:2784) dosyscall64 (arch/x86/entry/syscall64.c:63 arch/x86/entry/syscall64.c:94) entrySYSCALL64afterhwframe (arch/x86/entry/entry64.S:121)