GHSA-2ccx-2gf3-8xvv

Suggest an improvement
Source
https://github.com/advisories/GHSA-2ccx-2gf3-8xvv
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/01/GHSA-2ccx-2gf3-8xvv/GHSA-2ccx-2gf3-8xvv.json
JSON Data
https://api.test.osv.dev/v1/vulns/GHSA-2ccx-2gf3-8xvv
Aliases
Published
2021-01-14T19:15:19Z
Modified
2023-11-01T04:52:44.217187Z
Severity
  • 6.8 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:N/I:H/A:N CVSS Calculator
Summary
Kirby .dev domains and some reverse proxy setups were treated as local
Details

Impact

About our registration block

In order to protect new installations on public servers that don't have an admin account for the Panel yet, we block account registration there by default. This is a security feature, which we implemented years ago in Kirby 2. It helps to avoid that you forget registering your first admin account on a public server.

In this case – without our security block – someone else might theoretically be able to find your site, find out it's running on Kirby, find the Panel and then register the account first. It's an unlikely situation, but it's still a certain risk.

To be able to register the first Panel account on a public server, you have to enforce the installer via a config setting. This helps to push all users to the best practice of registering your first Panel account on your local machine and upload it together with the rest of the site.

The issue

As noted by Jukka Rautanen, this installation block implementation in Kirby versions before 3.3.6 still assumed that .dev domains are local domains, which is no longer true. In the meantime, those domains became publicly available. This means that our installation block is no longer working as expected if you use a .dev domain for your Kirby site.

In fixing this issue, we've also found out that the local installation check may also fail if your site is behind a reverse proxy.

Am I affected?

You are only affected if:

  1. you use a .dev domain or your site is behind a reverse proxy &
  2. you have not yet registered your first Panel account on the public server &
  3. someone finds your site and tries to login at yourdomain.dev/panel before you register your first account.

You are not affected if you have already created one or multiple Panel accounts (no matter if on a .dev domain or behind a reverse proxy).

Patches

The problem has been patched in Kirby 2.5.14 and Kirby 3.3.6. Please update to one of these or a later version to fix the vulnerability.

Note: Kirby 2 reaches end of life on December 31, 2020. We therefore recommend to upgrade your Kirby 2 sites to Kirby 3. If you cannot upgrade, we still recommend to update to Kirby 2.5.14.

Workarounds

Kirby 2 sites on older releases can also be patched by applying the changes from this commit.

Database specific 
{
    "nvd_published_at": "2020-12-08T02:15:00Z",
    "github_reviewed_at": "2021-01-14T17:55:05Z",
    "severity": "MODERATE",
    "github_reviewed": true,
    "cwe_ids": [
        "CWE-346"
    ]
}
References

Affected packages

Packagist / getkirby/panel

Package

Name
getkirby/panel
Purl
pkg:composer/getkirby/panel

Affected ranges

Type
ECOSYSTEM
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
2.5.14

Affected versions

2.*

2.4.0
2.4.1
2.4.2
2.5.0
2.5.1
2.5.2
2.5.3
2.5.4
2.5.5-RC-1
2.5.5
2.5.6-RC-1
2.5.6
2.5.7-RC-1
2.5.7
2.5.8-RC-1
2.5.8
2.5.9-RC-1
2.5.9-RC-2
2.5.9
2.5.10
2.5.11-RC-1
2.5.11
2.5.12
2.5.13

Packagist / getkirby/cms

Package

Name
getkirby/cms
Purl
pkg:composer/getkirby/cms

Affected ranges

Type
ECOSYSTEM
Events
Introduced
3.0.0
Fixed
3.3.6

Affected versions

3.*

3.0.0
3.0.1-rc.1
3.0.1
3.0.2-rc.1
3.0.2
3.0.3-rc.1
3.0.3-rc.2
3.0.3-rc.3
3.0.3
3.1.0-rc.1
3.1.0
3.1.1
3.1.2-rc.1
3.1.2
3.1.3-rc.1
3.1.3
3.1.4-rc.1
3.1.4
3.2.0-rc.1
3.2.0-rc.2
3.2.0-rc.3
3.2.0-rc.4
3.2.0
3.2.1-rc.1
3.2.1
3.2.2
3.2.3-rc.1
3.2.3
3.2.4-rc.1
3.2.4
3.2.5-rc.1
3.2.5-rc.2
3.2.5
3.3.0-rc.1
3.3.0-rc.2
3.3.0-rc.3
3.3.0-rc.4
3.3.0-rc.5
3.3.0
3.3.1-rc.1
3.3.1
3.3.2-rc.1
3.3.2
3.3.3-rc.1
3.3.3
3.3.4-rc.1
3.3.4
3.3.5-rc.1
3.3.5