GHSA-2r6j-862c-m2v2
Suggest an improvement- Source
- https://github.com/advisories/GHSA-2r6j-862c-m2v2
- Import Source
- https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/03/GHSA-2r6j-862c-m2v2/GHSA-2r6j-862c-m2v2.json
- JSON Data
- https://api.test.osv.dev/v1/vulns/GHSA-2r6j-862c-m2v2
- Aliases
- Published
- 2021-03-23T01:53:52Z
- Modified
- 2024-02-02T17:00:57.008876Z
- Severity
-
- 8.6 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:H/A:L/E:F/RL:O/RC:C CVSS Calculator
- Summary
- Unrestricted File Upload in Form Framework
- Details
-
Problem
Due to the lack of ensuring file extensions belong to configured allowed mime-types, attackers can upload arbitrary data with arbitrary file extensions - however, default fileDenyPattern successfully blocked files like .htaccess or malicious.php.
TYPO3 Extbase extensions, which implement a file upload and do not implement a custom TypeConverter to transform uploaded files into FileReference domain model objects are affected by the vulnerability as well, since the UploadedFileReferenceConverter of ext:form handles the file upload and will accept files of any mime-type which are persisted to the default location.
In any way, uploaded files are placed in the default location /fileadmin/userupload/_, in most scenarios keeping the submitted filename - which allows attackers to directly reference files, or even correctly guess filenames used by other individuals, disclosing this information.
No authentication is required to exploit this vulnerability.
Solution
Update to TYPO3 versions 8.7.40, 9.5.25, 10.4.14, 11.1.1 that fix the problem described.
Type converter UploadedFileReferenceConverter is not registered globally anymore and just handles uploaded files within the scope of the Form Framework. Guessable storage location has changed from /fileadmin/userupload/form_\<random-hash\>/_ to /fileadmin/formuploads/<random-40-bit>. Allowed mime-types must match expected file extensions (e.g. _application/pdf must be .pdf, and cannot be .html).
Extbase extensions, who rely on the global availability of the UploadedFileReferenceConverter must now implement a custom TypeConverter to handle file uploads or explicitly implement the ext:form UploadedFileReferenceConverter with appropriate setting for accepted mime-types.
Credits
Thanks to Sebastian Michaelsen, Marc Lindemann, Oliver Eglseder, Markus Volkmer, Jakob Kunzmann, Johannes Regner, Richie Lee who reported this issue, and to TYPO3 core & security team members Oliver Hader & Benni Mack, as well as TYPO3 contributor Ralf Zimmermann who fixed the issue.
References
- Database specific
{ "nvd_published_at": "2021-03-23T02:15:00Z", "cwe_ids": [ "CWE-434", "CWE-552" ], "severity": "HIGH", "github_reviewed": true, "github_reviewed_at": "2021-03-23T01:41:38Z" }- References
-
- https://github.com/TYPO3/TYPO3.CMS/security/advisories/GHSA-2r6j-862c-m2v2
- https://nvd.nist.gov/vuln/detail/CVE-2021-21355
- https://github.com/FriendsOfPHP/security-advisories/blob/master/typo3/cms-core/CVE-2021-21355.yaml
- https://github.com/FriendsOfPHP/security-advisories/blob/master/typo3/cms/CVE-2021-21355.yaml
- https://packagist.org/packages/typo3/cms-form
- https://typo3.org/security/advisory/typo3-core-sa-2021-002
Affected packages
Packagist / typo3/cms-form
Package
- Name
- typo3/cms-form
- Purl
- pkg:composer/typo3/cms-form
Packagist / typo3/cms-form
Package
- Name
- typo3/cms-form
- Purl
- pkg:composer/typo3/cms-form
Packagist / typo3/cms-form
Package
- Name
- typo3/cms-form
- Purl
- pkg:composer/typo3/cms-form
Packagist / typo3/cms-form
Package
- Name
- typo3/cms-form
- Purl
- pkg:composer/typo3/cms-form
Packagist / typo3/cms-core
Package
- Name
- typo3/cms-core
- Purl
- pkg:composer/typo3/cms-core
Packagist / typo3/cms-core
Package
- Name
- typo3/cms-core
- Purl
- pkg:composer/typo3/cms-core
Packagist / typo3/cms-core
Package
- Name
- typo3/cms-core
- Purl
- pkg:composer/typo3/cms-core
Packagist / typo3/cms
Package
- Name
- typo3/cms
- Purl
- pkg:composer/typo3/cms
Packagist / typo3/cms
Package
- Name
- typo3/cms
- Purl
- pkg:composer/typo3/cms
Packagist / typo3/cms
Package
- Name
- typo3/cms
- Purl
- pkg:composer/typo3/cms