GHSA-3j4h-h3fp-vwww
Suggest an improvement- Source
- https://github.com/advisories/GHSA-3j4h-h3fp-vwww
- Import Source
- https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2024/06/GHSA-3j4h-h3fp-vwww/GHSA-3j4h-h3fp-vwww.json
- JSON Data
- https://api.test.osv.dev/v1/vulns/GHSA-3j4h-h3fp-vwww
- Aliases
-
- CVE-2024-34694
- Published
- 2024-06-17T21:24:18Z
- Modified
- 2024-06-26T05:31:18.422955Z
- Severity
-
- 8.1 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:H/A:H CVSS Calculator
- Summary
- LNbits improperly handles potential network and payment failures when using Eclair backend
- Details
-
Summary
Paying invoices in Eclair that do not get settled within the internal timeout (about 30s) lead to a payment being considered failed, even though it may still be in flight.
Details
Using
blocking: trueon the API call will lead to a timeout error if a payment does not get settled in the 30s timeout with the error:Ask timed out on [Actor[akka://eclair-node/user/$l#134241942]] after [30000 ms]. Message of type [fr.acinq.eclair.payment.send.PaymentInitiator$SendPaymentToNode]. A typical reason for AskTimeoutException is that the recipient actor didn't send a reply.https://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L138This is considered a payment failure by parts of the code, and assumes the payment is not going to be settled after: https://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L144 https://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L141 https://github.com/lnbits/lnbits/blob/c04c13b2f8cfbb625571a07dfddeb65ea6df8dac/lnbits/wallets/eclair.py#L146
The best way to fix this is to check the payment status after an error, and when not sure, always consider a payment still in flight.
PoC
A very simple way to exploit this is: - Create a hold invoice - Pay the invoice with the LNbits server backed by an Eclair node, until it times out - Settle the hold invoice
Impact
This vulnerability can lead to a total loss of funds for the node backend.
- Database specific
{ "nvd_published_at": "2024-06-14T15:15:50Z", "cwe_ids": [ "CWE-754" ], "severity": "HIGH", "github_reviewed": true, "github_reviewed_at": "2024-06-17T21:24:18Z" }- References
Affected packages
PyPI / lnbits
Package
- Name
- lnbits
- View open source insights on deps.dev
- Purl
- pkg:pypi/lnbits