GHSA-5824-cm3x-3c38

Source

https://github.com/advisories/GHSA-5824-cm3x-3c38

Import Source

https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/08/GHSA-5824-cm3x-3c38/GHSA-5824-cm3x-3c38.json

JSON Data

https://api.test.osv.dev/v1/vulns/GHSA-5824-cm3x-3c38

Aliases

Published

2023-08-09T14:27:57Z

Modified

2024-10-14T18:27:01.835509Z

Severity

8.7 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:N/I:H/A:H CVSS Calculator
9.1 (Critical) CVSS_V4 - CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:H/VA:H/SC:N/SI:H/SA:H/E:A CVSS Calculator

Summary

Vyper has incorrectly allocated named re-entrancy locks

Details

Impact

In versions 0.2.15, 0.2.16 and 0.3.0, named re-entrancy locks are allocated incorrectly. Each function using a named re-entrancy lock gets a unique lock regardless of the key, allowing cross-function re-entrancy in contracts compiled with the susceptible versions. A specific set of conditions is required to result in misbehavior of affected contracts, specifically:

A .vy contract compiled with either of the following vyper versions: 0.2.15, 0.2.16, 0.3.0
A primary function that utilizes the @nonreentrant decorator with a specific key and does not strictly follow the check-effects-interaction pattern (i.e. contains an external call to an untrusted party before storage updates)
A secondary function that utilizes the same key and would be affected by the improper state caused by the primary function

Patches

https://github.com/vyperlang/vyper/pull/2439, https://github.com/vyperlang/vyper/pull/2514

Workarounds

Upgrade to 0.3.1 or higher

References

Technical post-mortem report: https://hackmd.io/@vyperlang/HJUgNMhs2

Database specific

{
    "nvd_published_at": "2023-08-07T19:15:11Z",
    "cwe_ids": [
        "CWE-863"
    ],
    "severity": "CRITICAL",
    "github_reviewed": true,
    "github_reviewed_at": "2023-08-09T14:27:57Z"
}

References

Affected packages

PyPI / vyper

Package

Name: vyper; View open source insights on deps.dev
Purl: pkg:pypi/vyper

Affected ranges

Type: ECOSYSTEM
Events: Introduced

0.2.15

Fixed

0.3.1

Affected versions

0.*

0.2.15

0.2.16

0.3.0