GHSA-5jqp-qgf6-3pvh

Suggest an improvement
Source
https://github.com/advisories/GHSA-5jqp-qgf6-3pvh
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2021/05/GHSA-5jqp-qgf6-3pvh/GHSA-5jqp-qgf6-3pvh.json
JSON Data
https://api.test.osv.dev/v1/vulns/GHSA-5jqp-qgf6-3pvh
Aliases
Published
2021-05-13T20:23:17Z
Modified
2024-10-21T20:25:56.797869Z
Severity
  • 3.3 (Low) CVSS_V3 - CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:N/I:N/A:L CVSS Calculator
  • 5.3 (Medium) CVSS_V4 - CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:P/VC:N/VI:N/VA:L/SC:N/SI:N/SA:N CVSS Calculator
Summary
Use of "infinity" as an input to datetime and date fields causes infinite loop in pydantic
Details

Impact

Passing either 'infinity', 'inf' or float('inf') (or their negatives) to datetime or date fields causes validation to run forever with 100% CPU usage (on one CPU). Patches

Pydantic is be patched with fixes available in the following versions:

v1.8.2
v1.7.4
v1.6.2

All these versions are available on pypi, and will be available on conda-forge soon.

See the changelog for details. Workarounds

If you absolutely can't upgrade, you can work around this risk using a validator to catch these values, brief demo:

from datetime import date from pydantic import BaseModel, validator

class DemoModel(BaseModel): dateofbirth: date

@validator('date_of_birth', pre=True)
def skip_infinite_values(cls, v):
    try:
        seconds = float(v)
    except (ValueError, TypeError):
        return v
    else:
        if seconds == float('inf'):
            return date.max
        elif seconds == float('-inf'):
            return date.min
        else:
            return seconds

Note: this is not an ideal solution (in particular you'll need a slightly different function for datetimes), instead of a hack like this you should upgrade pydantic.

If you are not using v1.8.x, v1.7.x or v1.6.x and are unable to upgrade to a fixed version of pydantic, please create an issue requesting a back-port, and we will endeavour to release a patch for earlier versions of pydantic. References

This was fixed in commit 7e83fdd.

Database specific
{
    "nvd_published_at": "2021-05-13T19:15:00Z",
    "cwe_ids": [
        "CWE-835"
    ],
    "severity": "MODERATE",
    "github_reviewed": true,
    "github_reviewed_at": "2021-05-13T18:54:35Z"
}
References

Affected packages

PyPI / pydantic

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
1.6.2

Affected versions

0.*

0.0.1
0.0.2
0.0.3
0.0.4
0.0.5
0.0.6
0.0.7
0.0.8
0.1
0.2
0.2.1
0.3
0.4
0.5
0.6
0.6.1
0.6.2
0.6.3
0.6.4
0.7
0.7.1
0.8
0.9
0.9.1
0.10
0.11
0.11.1
0.11.2
0.12
0.12.1
0.13
0.13.1
0.14
0.15
0.16
0.16.1
0.17
0.18
0.18.1
0.18.2
0.19
0.20a1
0.20
0.20.1
0.21
0.22
0.23
0.24
0.25
0.26
0.27a1
0.27
0.28
0.29
0.30
0.30.1
0.31
0.31.1
0.32
0.32.1
0.32.2

1.*

1.0b1
1.0b2
1.0
1.1
1.1.1
1.2
1.3
1.4
1.5
1.5.1
1.6
1.6.1

PyPI / pydantic

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
1.8
Fixed
1.8.2

Affected versions

1.*

1.8
1.8.1

PyPI / pydantic

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
1.7
Fixed
1.7.4

Affected versions

1.*

1.7
1.7.1
1.7.2
1.7.3