GHSA-c5v8-2q4r-5w9v

Suggest an improvement
Source
https://github.com/advisories/GHSA-c5v8-2q4r-5w9v
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/09/GHSA-c5v8-2q4r-5w9v/GHSA-c5v8-2q4r-5w9v.json
JSON Data
https://api.test.osv.dev/v1/vulns/GHSA-c5v8-2q4r-5w9v
Aliases
Published
2022-09-16T17:36:44Z
Modified
2023-11-01T04:59:31.700190Z
Severity
  • 9.9 (Critical) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:C/C:H/I:H/A:H CVSS Calculator
Summary
XWiki Platform Mentions UI vulnerable to Cross-site Scripting
Details

Impact

It's possible to store Javascript or groovy scripts in an mention macro anchor or reference field. The stored code is executed by anyone visiting the page with the mention.

For example, the example below will create a file at /tmp/exploit.txt:

{{mention reference="XWiki.Translation" anchor="{{/html~}~}{{async async=~"true~" cached=~"false~" context=~"doc.reference~"~}~}{{groovy~}~}new File(~"/tmp/exploit.txt~").withWriter { out -> out.println(~"owned!~"); }{{/groovy~}~}{{/async~}~}"/}}

Patches

This issue has been patched on XWiki 14.4 and 13.10.6.

Workarounds

It's possible to fix the vulnerability by updating XWiki.Mentions.MentionsMacro and edit the Macro code field of the XWiki.WikiMacroClass XObject.

<a id="$anchor" class="$stringtool.join($cssClasses, ' ')" data-reference="$services.model.serialize($reference.reference, 'default')" href="$link">$content</a>

Must be replaced by

<a id="$escapetool.xml($anchor)" class="$stringtool.join($cssClasses, ' ')" data-reference="$escapetool.xml($services.model.serialize($reference.reference, 'default'))" href="$escapetool.xml($link)">
  $escapetool.xml($content)
</a>

See the patches: - 14.4: https://github.com/xwiki/xwiki-platform/commit/4f290d87a8355e967378a1ed6aee23a06ba162eb - 13.10.6: https://github.com/xwiki/xwiki-platform/commit/4032dc896857597efd169966dc9e2752a9fdd459#diff-4fe22885f772e47d3561a05348f73921669ec12d4413b220383b73c7ae484bc4R608-R610

References

  • https://jira.xwiki.org/browse/XWIKI-19752

For more information

If you have any questions or comments about this advisory:

Database specific
{
    "nvd_published_at": "2022-09-08T21:15:00Z",
    "github_reviewed_at": "2022-09-16T17:36:44Z",
    "severity": "CRITICAL",
    "github_reviewed": true,
    "cwe_ids": [
        "CWE-79"
    ]
}
References

Affected packages

Maven / org.xwiki.platform:xwiki-platform-mentions-ui

Package

Name
org.xwiki.platform:xwiki-platform-mentions-ui
View open source insights on deps.dev
Purl
pkg:maven/org.xwiki.platform/xwiki-platform-mentions-ui

Affected ranges

Type
ECOSYSTEM
Events
Introduced
12.5-rc-1
Fixed
13.10.6

Maven / org.xwiki.platform:xwiki-platform-mentions-ui

Package

Name
org.xwiki.platform:xwiki-platform-mentions-ui
View open source insights on deps.dev
Purl
pkg:maven/org.xwiki.platform/xwiki-platform-mentions-ui

Affected ranges

Type
ECOSYSTEM
Events
Introduced
14.0
Fixed
14.4