GHSA-j563-grx4-pjpv

Suggest an improvement
Source
https://github.com/advisories/GHSA-j563-grx4-pjpv
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/12/GHSA-j563-grx4-pjpv/GHSA-j563-grx4-pjpv.json
JSON Data
https://api.test.osv.dev/v1/vulns/GHSA-j563-grx4-pjpv
Aliases
Published
2022-12-29T01:48:08Z
Modified
2023-11-01T05:30:25.195086Z
Severity
  • 8.2 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:H CVSS Calculator
Summary
XStream can cause Denial of Service via stack overflow
Details

Impact

The vulnerability may allow a remote attacker to terminate the application with a stack overflow error resulting in a denial of service only by manipulating the processed input stream.

Patches

XStream 1.4.20 handles the stack overflow and raises an InputManipulationException instead.

Workarounds

The attack uses the hash code implementation for collections and maps to force recursive hash calculation causing a stack overflow. Following types of the Java runtime are affected:

  • java.util.HashMap
  • java.util.HashSet
  • java.util.Hashtable
  • java.util.LinkedHashMap
  • java.util.LinkedHashSet
  • Other third party collection implementations that use their element's hash code may also be affected

A simple solution is to catch the StackOverflowError in the client code calling XStream.

If your object graph does not use referenced elements at all, you may simply set the NO_REFERENCE mode:

XStream xstream = new XStream();
xstream.setMode(XStream.NO_REFERENCES);

If your object graph contains neither a Hashtable, HashMap nor a HashSet (or one of the linked variants of it) then you can use the security framework to deny the usage of these types:

XStream xstream = new XStream();
xstream.denyTypes(new Class[]{
 java.util.HashMap.class, java.util.HashSet.class, java.util.Hashtable.class, java.util.LinkedHashMap.class, java.util.LinkedHashSet.class
});

Unfortunately these types are very common. If you only use HashMap or HashSet and your XML refers these only as default map or set, you may additionally change the default implementation of java.util.Map and java.util.Set at unmarshalling time::

xstream.addDefaultImplementation(java.util.TreeMap.class, java.util.Map.class);
xstream.addDefaultImplementation(java.util.TreeSet.class, java.util.Set.class);

However, this implies that your application does not care about the implementation of the map and all elements are comparable.

References

See full information about the nature of the vulnerability and the steps to reproduce it in XStream's documentation for CVE-2022-41966.

For more information

If you have any questions or comments about this advisory: * Open an issue in XStream * Contact us at XStream Google Group

Database specific
{
    "nvd_published_at": "2022-12-28T00:15:00Z",
    "cwe_ids": [
        "CWE-120",
        "CWE-121",
        "CWE-502",
        "CWE-674"
    ],
    "severity": "HIGH",
    "github_reviewed": true,
    "github_reviewed_at": "2022-12-29T01:48:08Z"
}
References

Affected packages

Maven / com.thoughtworks.xstream:xstream

Package

Name
com.thoughtworks.xstream:xstream
View open source insights on deps.dev
Purl
pkg:maven/com.thoughtworks.xstream/xstream

Affected ranges

Type
ECOSYSTEM
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
1.4.20

Affected versions

0.*

0.1
0.2
0.3
0.5
0.6

1.*

1.0
1.0.1
1.0.2
1.1
1.1.1
1.1.2
1.1.3
1.2
1.2.1
1.2.2
1.3
1.3.1
1.4
1.4.1
1.4.2
1.4.3
1.4.4
1.4.5
1.4.6
1.4.7
1.4.8
1.4.9
1.4.10
1.4.10-java7
1.4.11
1.4.11-java7
1.4.11.1
1.4.12
1.4.12-java7
1.4.13
1.4.13-java7
1.4.14
1.4.14-java7
1.4.14-jdk7
1.4.15
1.4.16
1.4.17
1.4.18
1.4.19