GHSA-pffg-92cg-xf5c

Source

https://github.com/advisories/GHSA-pffg-92cg-xf5c

Import Source

https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/10/GHSA-pffg-92cg-xf5c/GHSA-pffg-92cg-xf5c.json

JSON Data

https://api.test.osv.dev/v1/vulns/GHSA-pffg-92cg-xf5c

Aliases

GO-2023-2101

Published

2023-10-05T20:57:20Z

Modified

2024-05-20T21:55:42Z

Summary

gnark-crypto's exponentiation in the pairing target group GT using GLV can give incorrect results

Details

Impact

When the exponent is bigger than r, the group order of the pairing target group GT, the exponentiation à la GLV (ExpGLV) can sometimes give incorrect results compared to normal exponentiation (Exp).

The issue impacts all users using ExpGLV for exponentiations in GT. This does not impact Exp and ExpCyclotomic which are sound. Also note that GLV methods in G1 and G2 are sound and not impacted.

Patches

Fix has been implemented in pull request https://github.com/Consensys/gnark-crypto/pull/451 and merged in commit https://github.com/Consensys/gnark-crypto/commit/ec6be1a037f7c496d595c541a8a8d31c47bcfa3d to master branch.

The fix increased the bounds of the sub-scalars by 1. In fact, since https://github.com/Consensys/gnark-crypto/pull/213, we use a fast scalar decomposition that tradeoffs divisions (needed in the Babai rounding) by right-shifts. We precompute b=2^m*v/d (m > log2(d)) and then at runtime compute scalar*b/2^m (v is a lattice vector and d the lattice determinant). This increases the bounds on sub-scalars by 1 which we check at runtime before increasing the loop size (we don't target constant-timeness). m is chosen to be a machine word twice big than log2(d) so that we rarely need to increase the loop size. Hence why the issue happens only sometimes if we omit to increase the bounds. This bounds increase was implemented in G1 and G2 but forgot in GT.

Workarounds

Updating to v0.12.1+. Alternatively, use Exp or ExpCyclotomic instead. We are not aware of any users using ExpGLV anyway.

References

Fix PR: https://github.com/Consensys/gnark-crypto/pull/451
Fast scalar decomposition PR: https://github.com/Consensys/gnark-crypto/pull/213
https://eprint.iacr.org/2015/565 Sec.4.2

Acknowledgement

The vulnerability was reported by Antonio Sanso @ EF.

Database specific

{
    "nvd_published_at": null,
    "cwe_ids": [],
    "severity": "LOW",
    "github_reviewed": true,
    "github_reviewed_at": "2023-10-05T20:57:20Z"
}

References

Affected packages

Go / github.com/consensys/gnark-crypto

Package

Name: github.com/consensys/gnark-crypto; View open source insights on deps.dev
Purl: pkg:golang/github.com/consensys/gnark-crypto

Affected ranges

Type: SEMVER
Events: Introduced

0Unknown introduced version / All previous versions are affected

Fixed

0.12.1

Database specific

{
    "last_known_affected_version_range": "<= 0.12.0"
}