GHSA-qh9x-gcfh-pcrw

Suggest an improvement
Source
https://github.com/advisories/GHSA-qh9x-gcfh-pcrw
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/07/GHSA-qh9x-gcfh-pcrw/GHSA-qh9x-gcfh-pcrw.json
JSON Data
https://api.test.osv.dev/v1/vulns/GHSA-qh9x-gcfh-pcrw
Aliases
Related
Published
2022-07-21T22:33:01Z
Modified
2023-11-01T04:59:00.196897Z
Severity
  • 7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N CVSS Calculator
Summary
OpenZeppelin Contracts's ERC165Checker may revert instead of returning false
Details

Impact

ERC165Checker.supportsInterface is designed to always successfully return a boolean, and under no circumstance revert. However, an incorrect assumption about Solidity 0.8's abi.decode allows some cases to revert, given a target contract that doesn't implement EIP-165 as expected, specifically if it returns a value other than 0 or 1.

The contracts that may be affected are those that use ERC165Checker to check for support for an interface and then handle the lack of support in a way other than reverting.

Patches

The issue was patched in 4.7.1.

References

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3552

For more information

If you have any questions or comments about this advisory, or need assistance deploying the fix, email us at security@openzeppelin.com.

Database specific
{
    "nvd_published_at": "2022-07-22T04:15:00Z",
    "github_reviewed_at": "2022-07-21T22:33:01Z",
    "severity": "HIGH",
    "github_reviewed": true,
    "cwe_ids": [
        "CWE-20",
        "CWE-252"
    ]
}
References

Affected packages

npm / @openzeppelin/contracts

Package

Name
@openzeppelin/contracts
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts

Affected ranges

Type
SEMVER
Events
Introduced
4.0.0
Fixed
4.7.1

npm / @openzeppelin/contracts-upgradeable

Package

Name
@openzeppelin/contracts-upgradeable
View open source insights on deps.dev
Purl
pkg:npm/%40openzeppelin/contracts-upgradeable

Affected ranges

Type
SEMVER
Events
Introduced
4.0.0
Fixed
4.7.1