GHSA-wc69-rhjr-hc9g

Suggest an improvement
Source
https://github.com/advisories/GHSA-wc69-rhjr-hc9g
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/07/GHSA-wc69-rhjr-hc9g/GHSA-wc69-rhjr-hc9g.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-wc69-rhjr-hc9g
Aliases
Published
2022-07-06T18:38:49Z
Modified
2024-02-18T05:20:51.155257Z
Severity
  • 7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H CVSS Calculator
Summary
Moment.js vulnerable to Inefficient Regular Expression Complexity
Details

Impact

  • using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic (N^2) complexity on specific inputs
  • noticeable slowdown is observed with inputs above 10k characters
  • users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks

Patches

The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.

Workarounds

In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.

References

There is an excellent writeup of the issue here: https://github.com/moment/moment/pull/6015#issuecomment-1152961973=

Details

The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process, which is unacceptable.

References

Affected packages

npm / moment

Package

Affected ranges

Type
SEMVER
Events
Introduced
2.18.0
Fixed
2.29.4

Ecosystem specific

{
    "affected_functions": [
        "(moment)"
    ]
}

NuGet / Moment.js

Package

Affected ranges

Type
ECOSYSTEM
Events
Introduced
2.18.0
Fixed
2.29.4

Affected versions

2.*

2.18.0
2.18.1
2.18.2
2.19.0
2.19.1
2.19.2
2.19.3
2.19.4
2.20.0
2.20.1
2.21.0
2.22.0
2.22.1
2.22.2
2.23.0
2.24.0
2.25.0
2.25.1
2.25.2
2.26.0
2.27.0
2.28.0
2.29.0
2.29.1
2.29.2
2.29.3