GHSA-xmgg-fx9p-prq6

Suggest an improvement
Source
https://github.com/advisories/GHSA-xmgg-fx9p-prq6
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/09/GHSA-xmgg-fx9p-prq6/GHSA-xmgg-fx9p-prq6.json
JSON Data
https://api.test.osv.dev/v1/vulns/GHSA-xmgg-fx9p-prq6
Aliases
Related
Published
2022-09-16T18:38:45Z
Modified
2023-11-01T04:59:30.571103Z
Severity
  • 7.5 (High) CVSS_V3 - CVSS:3.1/AV:N/AC:H/PR:N/UI:R/S:U/C:H/I:H/A:H CVSS Calculator
Summary
NodeBB account takeover via SSO plugins
Details

This is a historical security advisory, pertaining to a vulnerability that was reported, patched, and published in 2021. It is listed here for completeness and for CVE tracking purposes.

Impact

Due to an unnecessarily strict conditional in the code handling the first step of the SSO process, the pre-existing logic that added (and later checked) a nonce was inadvertently rendered opt-in instead of opt-out.

This re-exposed a vulnerability in that a specially crafted MITM attack could theoretically take over another user account during the single sign-on process.

Patches

The issue has been fully patched as of v1.17.2.

The patch commit can be found at https://github.com/NodeBB/NodeBB/commit/a2400f6baff44cb2996487bcd0cc6e2acc74b3d4

Workarounds

Site maintainers can cherry-pick https://github.com/NodeBB/NodeBB/commit/a2400f6baff44cb2996487bcd0cc6e2acc74b3d4 into their codebase to patch the exploit.

References

  • https://blogs.opera.com/security/2022/03/bug-bounty-adventures-a-nodebb-0-day/

For more information

If you have any questions or comments about this advisory: * Discuss it on our community forum * Email us at support@nodebb.org

Database specific
{
    "nvd_published_at": "2022-09-02T13:15:00Z",
    "cwe_ids": [
        "CWE-352"
    ],
    "severity": "HIGH",
    "github_reviewed": true,
    "github_reviewed_at": "2022-09-16T18:38:45Z"
}
References

Affected packages

npm / nodebb

Package

Affected ranges

Type
SEMVER
Events
Introduced
0Unknown introduced version / All previous versions are affected
Fixed
1.17.2

Database specific

{
    "last_known_affected_version_range": "<= 1.17.1"
}