GHSA-xwh9-gc39-5298

Suggest an improvement
Source
https://github.com/advisories/GHSA-xwh9-gc39-5298
Import Source
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2023/11/GHSA-xwh9-gc39-5298/GHSA-xwh9-gc39-5298.json
JSON Data
https://api.osv.dev/v1/vulns/GHSA-xwh9-gc39-5298
Aliases
Related
Published
2023-11-28T17:36:21Z
Modified
2024-05-20T21:58:12Z
Severity
  • 5.9 (Medium) CVSS_V3 - CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:N/A:N CVSS Calculator
Summary
github.com/go-resty/resty/v2 HTTP request body disclosure
Details

A race condition in go-resty can result in HTTP request body disclosure across requests.

This condition can be triggered by calling sync.Pool.Put with the same *bytes.Buffer more than once, when request retries are enabled and a retry occurs. The call to sync.Pool.Get will then return a bytes.Buffer that hasn't had bytes.Buffer.Reset called on it. This dirty buffer will contain the HTTP request body from an unrelated request, and go-resty will append the current HTTP request body to it, sending two bodies in one request.

The sync.Pool in question is defined at package level scope, so a completely unrelated server could receive the request body.

References

Affected packages

Go / github.com/go-resty/resty/v2

Package

Name
github.com/go-resty/resty/v2
View open source insights on deps.dev
Purl
pkg:golang/github.com/go-resty/resty/v2

Affected ranges

Type
SEMVER
Events
Introduced
2.10.0
Fixed
2.11.0